Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stream::min_by_key method #385

Merged
merged 6 commits into from
Oct 29, 2019
Merged

add stream::min_by_key method #385

merged 6 commits into from
Oct 29, 2019

Conversation

yjhmelody
Copy link
Contributor

k-nasa
k-nasa reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@k-nasa k-nasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pin-project-lite may be more concise.
Please refer to this PR.
#381

src/stream/stream/min_by_key.rs Outdated Show resolved Hide resolved
taiki-e
taiki-e reviewed Oct 26, 2019
View reviewed changes
src/stream/stream/min_by_key.rs Outdated Show resolved Hide resolved
src/stream/stream/min_by_key.rs Outdated Show resolved Hide resolved
src/stream/stream/min_by_key.rs Outdated Show resolved Hide resolved
src/stream/stream/mod.rs Show resolved Hide resolved
@taiki-e taiki-e mentioned this pull request Oct 26, 2019
Merged
@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 28, 2019
yoshuawuyts
yoshuawuyts approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 5ff4ef8 into async-rs:master Oct 29, 2019
@yjhmelody yjhmelody deleted the stream-min_by_key branch October 29, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e left review comments

@k-nasa k-nasa k-nasa left review comments

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yjhmelody @yoshuawuyts @k-nasa @taiki-e