Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration tests scripts #316

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Dec 6, 2024

When running locally, they would generate a symbolic link inside the dags symbolic link, if it previously existed.

This PR solves these limitations.

When running locally, they would generate a symbolic link inside the dags symbolic link, if it previously existed
@tatiana tatiana marked this pull request as ready for review December 6, 2024 17:13
@tatiana tatiana requested a review from a team as a code owner December 6, 2024 17:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (8e27a98) to head (e494f14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          10       10           
  Lines         776      776           
=======================================
  Hits          724      724           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor suggestion inline.

scripts/test/integration-setup.sh Outdated Show resolved Hide resolved
@tatiana tatiana merged commit 017bc30 into main Dec 9, 2024
1 check passed
@tatiana tatiana deleted the improve-integration-tests-scripts branch December 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants