-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tested task group @glazunov996 #292
Conversation
Co-authored-by: glazunov996 <glazunov996>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 93.95% 93.22% -0.74%
==========================================
Files 8 8
Lines 645 664 +19
==========================================
+ Hits 606 619 +13
- Misses 39 45 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good to me, have some comments inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing the previous comments so quickly!
This PR adds an example for the task group. Depend on PR: #292 <img width="1678" alt="Screenshot 2024-11-19 at 6 23 42 PM" src="https://github.com/user-attachments/assets/7203fc6a-940b-4a99-9fc2-c189b0fb70b6">
### Added - Add support to TaskFlow and improve dynamic task mapping support by @tatiana in #314 - Render YML DAG config as DAG Docs by @pankajastro #305 - Support building DAGs out of topologically unsorted YAML files by @tatiana in #307 - Add support for nested task groups by @glazunov996 and @pankajastro in #292 - Add support for templating `on_failure_callback` by @jroach-astronomer #252 ### Fixed - Fix compatibility with apache-airflow-providers-cncf-kubernetes>=10.0.0 by @tatiana in #311 - Refactor telemetry to collect events during DAG run and not during DAG parsing by @pankajastro #300 ### Docs - Fix reference for HttpSensor in README.md by @pankajastro in #277 - Add example DAG for task group by @pankajastro in #293 - Add CODEOWNERS by @pankajkoti in #270 - Update CODEOWNERS to track all files by @pankajkoti in #276 - Modified Status badge in README by @jaejun #298 ### Others - Refactor dynamic task mapping implementation by @tatiana in #313 - Remove pytest durations from tests by @tatiana in #309 - Remove DAG retries check since many DAGs have different retry values by @tatiana in #310 - Lint fixes after running `pre-commit run --all-files` by @tatiana in #312 - Remove redundant exception code by @pankajastro #294 - Add GitHub issue template for bug reports and feature requests by @pankajkoti in #269 Closes: #223
Resolves Nested Subgroups #119 issue
Original PR: #141
Co-authored-by: Kuris [email protected]
closes: #119
Example YML DAG