Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to rust version 1.83 #1857

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

ethanoroshiba
Copy link
Contributor

@ethanoroshiba ethanoroshiba commented Dec 6, 2024

Summary

Bumped MSRV to 1.83 and made small changes to appease new Clippy lints.

Background

Rust 1.83 solves some bizarre Clippy false positives, improved lints also revealed some nit improvement points. Bumping MSRV also doesn't have a huge cost, since we don't have many downstream users.

Changes

  • Bumped MSRV.
  • Changed small bits to appease Clippy, mostly changing to use implicit lifetimes.
  • rustfmt made a bunch of changes with the new version

Testing

Passing all tests.

Changelogs

Changelogs updated for crates which have already been released.

Related Issues

closes #1580

@github-actions github-actions bot added ci issues that are related to ci and github workflows conductor pertaining to the astria-conductor crate proto pertaining to the Astria Protobuf spec sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer labels Dec 6, 2024
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner December 11, 2024 16:22
@github-actions github-actions bot added the proto pertaining to the Astria Protobuf spec label Dec 11, 2024
@ethanoroshiba ethanoroshiba changed the title chore: bump MSRV chore: bump to rust version 1.83 Dec 11, 2024
@ethanoroshiba ethanoroshiba removed the proto pertaining to the Astria Protobuf spec label Dec 11, 2024
@github-actions github-actions bot added the proto pertaining to the Astria Protobuf spec label Dec 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 16, 2024
…1863)

## Summary
Changed block channel to use boxed sequencer blocks.

## Background
Running clippy with Rust 1.83.0 in #1857 triggered a lint for large
error variant in the send methods for `BlobSubmitterHandle`. Large enum
variants (including in Results) should be avoided because they are only
as small as their largest variant:
https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err.
Creating the channel with a boxed block tackles this problem at its
source.

## Changes
- Boxed `SequencerBlock` in `BlobSubmitterHandle`, which tackles the
problem of potentially large send errors at its source.

## Testing
Passing all tests

## Changelogs
No updates required.

## Breaking Changes
Overridden code freeze since this is a very small, non breaking change
that shouldn't have any bearing since our previous audit.

## Related Issues
closes #1860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues that are related to ci and github workflows composer pertaining to composer conductor pertaining to the astria-conductor crate docker override-freeze proto pertaining to the Astria Protobuf spec sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove allow_attributes false positive exceptions once Rust is updated
2 participants