fix(sequencer): grpc height hack to fix ibc invalid proof error #1488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
patch penumbra and our hermes fork temporarily so that height is passed from hermes's requests to the ibc grpc server.
Background
there was an IBC proof validation failure error on dusk-10. the computed app hash was one height after the expected app hash, which could be caused by the grpc queries always using the latest state snapshot, instead of at the height intended by hermes. however the grpc requests don't contain the height (:/) so the hack is to put the height in the grpc request metadata, which is then used by the grpc query server to use the correct snapshot.
the actual fix is to get cosmos/ibc-go#5685 merged and put the heights in the actual grpc requests.
Changes
query_packet_receipt
andquery_packet_acknowledgement
grpc metadata hermes#12Testing
ibc smoke test