Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sequencer): grpc height hack to fix ibc invalid proof error #1488

Closed
wants to merge 4 commits into from

Conversation

noot
Copy link
Collaborator

@noot noot commented Sep 11, 2024

Summary

patch penumbra and our hermes fork temporarily so that height is passed from hermes's requests to the ibc grpc server.

Background

there was an IBC proof validation failure error on dusk-10. the computed app hash was one height after the expected app hash, which could be caused by the grpc queries always using the latest state snapshot, instead of at the height intended by hermes. however the grpc requests don't contain the height (:/) so the hack is to put the height in the grpc request metadata, which is then used by the grpc query server to use the correct snapshot.

the actual fix is to get cosmos/ibc-go#5685 merged and put the heights in the actual grpc requests.

Changes

Testing

ibc smoke test

@github-actions github-actions bot added the cd label Sep 11, 2024
@noot
Copy link
Collaborator Author

noot commented Sep 25, 2024

closing in favour of #1491 for now

@noot noot closed this Sep 25, 2024
@noot noot deleted the noot/ibc-height-fix branch November 7, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant