Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pubgrub to new add_incompatibility_from_dependencies #4062

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Jun 5, 2024

We had previously changed the signature of DependencyProvider::get_dependencies to return an iterator instead of a hashmap to avoid the conversion cost from our dependencies Vec to the pubgrub's hashmap. These changes are difficult to make in pubgrub since they complicate the public api. But we don't actually use DependencyProvider::get_dependencies, so we rolled those customizations back in pubgrub-rs/pubgrub#226 and instead opted to change only the internal add_incompatibility_from_dependencies method that we exposed in our fork. This aligns us closer with upstream, removes the design questions about DependencyProvider from our concerns and reduces our diff (not counting the github action) to +36 -12.

We had previously changed the signature of `DependencyProvider::get_dependencies` to return an iterator instead of a hashmap to avoid the conversion cost from our dependencies `Vec` to the pubgrub's hashmap. These changes are difficult to make in pubgrub since they complicate the public api. But we don't actually use `DependencyProvider::get_dependencies`, so we rolled those customizations back in pubgrub-rs/pubgrub#226 and instead opted to change only the internal `add_incompatibility_from_dependencies` method that we exposed in our fork. This aligns us closer with upstream, removes the design questions about `DependencyProvider` from our concerns and reduces our diff (not counting the github action) to +36 -12.
@konstin konstin merged commit 8596525 into main Jun 5, 2024
46 checks passed
@konstin konstin deleted the konsti/update-pubgrub-dp-impl branch June 5, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant