-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pycodestyle
] Implement missing-or-outdented-indentation
(E122
)
#11349
base: main
Are you sure you want to change the base?
Conversation
a129b34
to
5e21274
Compare
CodSpeed Performance ReportMerging #11349 will not alter performanceComparing Summary
|
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
E122 | 13 | 13 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
c9c5e0c
to
50ba417
Compare
add498e
to
ab87a33
Compare
@MichaReiser Could you review this when you get the chance? Thanks. Note when reviewing: pycodestyle allows two types of indentation: hanging indent and visual indent. However, it does not enforce a single style. Which is to say that even if one style is violated, if the other is followed then no error is reported. Therefore even though this rule doesn't check for visual indentation, it still needs to establish if visual indentation is present in order to match the pycodestyle behavior. |
Summary
Following the discussion in #8557, and since no more work has been done since then, I thought I would take a stab at
E122
.Part of #2402.
Test Plan
Test fixtures added.
I also validated the output against pycodestyle on some of the ecosystem repos.