Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 documentation #79

Closed
wants to merge 1 commit into from
Closed

ES6 documentation #79

wants to merge 1 commit into from

Conversation

PEM--
Copy link

@PEM-- PEM-- commented Jan 5, 2017

See #52

@astorije
Copy link
Owner

astorije commented Jan 8, 2017

Hey @PEM--, thank you very much for this!
Note that changes to the README should come along with the respective code comment. For example, .empty's doc in the README matches this comment in the code.

At this point, this should be tied to #74, which is one of the 2 things that will trigger the v2 of this plugin.

I'll ping you when I start porting this repo to ES6.

@astorije astorije added this to the v2.0.0 milestone Jan 8, 2017
@PEM--
Copy link
Author

PEM-- commented Jan 8, 2017

Hi @astorije. Thanks for this nice addition to my test suite. For easing the port to ES6, you should definitely have a look at: http://lebab.io/ 😉

@astorije
Copy link
Owner

Hey @PEM--, sorry for the long, loooong delay. Would you mind rebasing on master and fixing conflicts please? :)

@astorije
Copy link
Owner

Closing this as I expect #142 will supersede it. Thanks for your help @PEM--!!

@astorije astorije closed this May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants