Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detailed report, fix report creation #875

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

Arieg419
Copy link
Collaborator

No description provided.

Comment on lines 141 to 147
# subtopics_prompt = generate_subtopics_prompt().format(
# task=self.researcher.query,
# data=self.researcher.context,
# subtopics=self.researcher.subtopics,
# max_subtopics=self.researcher.max_subtopics,
# format_instructions="Return the subtopics as a list of strings."
# )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# subtopics_prompt = generate_subtopics_prompt().format(
# task=self.researcher.query,
# data=self.researcher.context,
# subtopics=self.researcher.subtopics,
# max_subtopics=self.researcher.max_subtopics,
# format_instructions="Return the subtopics as a list of strings."
# )

@onlydole
Copy link
Contributor

@Arieg419 - do you know if this passes the test suite (or if it runs via docker compose)?

@Arieg419 Arieg419 marked this pull request as draft October 1, 2024 02:11
@Arieg419
Copy link
Collaborator Author

Arieg419 commented Oct 1, 2024

hey @onlydole , i've moved this back to draft for now and am working through it --

The current state is that the 'detailed report' end report looks good but streams redundant intermediate steps to the UI.

I tried to bisect and reverted to about two weeks ago, and I am also getting a janky, concise 'detailed report' (shorter than a basic report), so I am wondering when it last worked. If there was a known hash where it functioned well, I'm happy to work off that, @assafelovic; otherwise, I think I'll have a fix for this tomorrow.

@Arieg419
Copy link
Collaborator Author

Arieg419 commented Oct 1, 2024

cc @assafelovic detailed report looks good now, however, it's still missing references. will add tomorrow, and publish the PR for review.

@assafelovic assafelovic marked this pull request as ready for review October 1, 2024 14:33
@assafelovic assafelovic merged commit 4f10f7b into master Oct 1, 2024
@Arieg419 Arieg419 deleted the detailed_report_support branch October 1, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants