Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Docker files optimization. #843

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Simple Docker files optimization. #843

merged 3 commits into from
Sep 15, 2024

Conversation

yigit353
Copy link
Contributor

The version tag at the beginning of the docker-compose.yml file is obsolete, so I just removed it.

Also, in Dockerfile, FROM and as should have the same capitalization, so I capitalized as into AS for consistency.

ElishaKay
ElishaKay approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@ElishaKay ElishaKay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled & tested.
works as expected

@ElishaKay ElishaKay merged commit 316ad40 into assafelovic:master Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElishaKay ElishaKay ElishaKay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yigit353 @ElishaKay