Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Default retriever, sanitizing #683

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

ruzicka02
Copy link
Contributor

Default retriever

In the previous version, the default case in get_retriever() meant
that setting retriever from config (as opposed to the header) was
ignored, and instead, the default (tavily) retriever was chosen.
Added new function to get the default retriever.

Corrected sanitizing

Sanitizing function replaces the slashes in the path, which is
most likely undesired. Discussed in
#679 (comment)

In the previous version, the default case in get_retriever() meant
that setting retriever from config (as opposed to the header) was
ignored, and instead, the default (tavily) retriever was chosen.
Added new function to get the default retriever.
Copy link
Owner

@assafelovic assafelovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thank you!

@assafelovic assafelovic merged commit 98100e9 into assafelovic:master Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants