Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump all dependendies to latest #137

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

gregmagolan
Copy link
Member

It is much simpler and faster to bump all dependencies to the latest then it is to determine what is the minimal set for Bazel 7 support.

Same as aspect-build/rules_esbuild#174.

@gregmagolan gregmagolan marked this pull request as draft January 6, 2024 04:37
@gregmagolan gregmagolan force-pushed the bump_deps__windows branch 7 times, most recently from 3180e33 to 64abab4 Compare January 7, 2024 20:38
@gregmagolan gregmagolan marked this pull request as ready for review January 7, 2024 20:38
@gregmagolan gregmagolan requested a review from jbedard January 7, 2024 20:38
@gregmagolan gregmagolan force-pushed the bump_deps__windows branch 2 times, most recently from efe2809 to 4b0c891 Compare January 7, 2024 20:42

load("@rules_jvm_external//:setup.bzl", "rules_jvm_external_setup")

rules_jvm_external_setup()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What change brought in all the stardoc+jvm requirements?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest stardoc now depends on rules_jvm_external

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and stardoc doesn't have a stardoc_deps() or something like that?

@gregmagolan gregmagolan marked this pull request as draft January 8, 2024 05:31
@gregmagolan gregmagolan requested review from jbedard and removed request for jbedard January 18, 2024 02:35
@titanous
Copy link

@gregmagolan any idea when this will be merged/released? We'd love to move to Bazel 7/bzlmod and this is a blocker.

@titanous
Copy link

Actually, looks like downgrading to aspect_bazel_lib 1.40.0 resolved the issue (related to #135)

@jbedard jbedard force-pushed the bump_deps__windows branch from 662c140 to 6a77ec7 Compare January 30, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants