Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay launchdir init until test execution #214

Merged
merged 1 commit into from
May 12, 2024

Conversation

jmuhlich
Copy link
Contributor

@jmuhlich jmuhlich commented May 1, 2024

This change separates the definition of the launch/meta/output/work directory paths from the physical re-initialization of the actual directories on the filesystem. The definition of the paths still happens up front, but the init and the rest of the setup() call has been moved down into the test execution engine inner loop. This prevents nf-test from changing the filesystem until the last moment before any given test actually runs. With this change, nf-test list or running specified tests no longer deletes the output from other tests. This also conveniently enables running tests in parallel without any extra filesystem isolation or containerization.

Fixes #213

@lukfor
Copy link
Collaborator

lukfor commented May 1, 2024

Thanks 🙏 I will go over the code and will merge it in the next few days 🚀

@lukfor lukfor merged commit c2734d9 into askimed:main May 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All tests' meta/output/work directories are deleted and recreated unnecessarily
2 participants