-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generator: Update list of vendor names #676
generator: Update list of vendor names #676
Conversation
This list is only used while stripping enum variant types ( |
That makes sense. I did make this change due to an upcoming additional vendor adding flag bits, but since its not in the public vk.xml I didn't want to add only the one that is needed. Should I close the PR? seems this commit goes against the established policy for this repo. |
@charles-lunarg That is the kind of issue I had in mind, after adding |
Ugh, just saw this in another PR half an hour ago: the freshly released I hope it's only the |
I don't think this is blocking upstream per-say, as the upstream CI checks don't fail if ash fails, it just documents that it didn't succeed. (Aka, a warning not an error). I will fix the formatting error. I'll just copy/paste what the formatter tells me it should be. But I'll wait till the bytemuck issue is resolved :) |
Sure, I set it up that way to not truly block everyone, but seeing a red/orange "CI failed with warnings" is never useful/nice 😉 Just run |
ac0a9bf
to
6543111
Compare
Let's see if #677 addresses the MSRV issue. |
@charles-lunarg You can rebase now :) EDIT: Looks like I get the update-branch button as well, but missed the arrow to do a rebase. That's fine, we'll squash-merge this anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, but one request: can we sort these alphabetically? 😬
ec83e61
to
ce308f8
Compare
ce308f8
to
68bdd0c
Compare
Alphabetical order is no issue, and it is much more pleasing to look at. |
@charles-lunarg Upstream CI should now be unblocked, which picks directly from the |
Thanks! |
Noticed that the vendor list is a bit on the lean side. I'm not sure what impact this will have (in fact, I didn't even run the code because I wasn't sure how to set up the rust environment to test it, and it seems like a 'no brain required' change.)
Regardless, while I would of liked to address the TODO to locate the vendors from the code directly, my rust isn't capable of that at the moment. Rather than ask one of the ash maintainers to do it, this lets any new vendor extensions not cause ash builds to fail.