-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip #37
wip #37
Conversation
539244e
to
7b75024
Compare
Being able to call |
But I can see the value in trying to stick with standard behavior. |
I just tried this PR by merging it onto the repo here and it's giving me this error
|
Can you post the contents of your direnvrc file? |
sorry for the late reply, it's literally just |
That doesn't sound right. You could of course include this line instead in every .envrc, but the global config is a more elegant way of doing it. |
Any plans on merging this @vic ? As far as I can remember these changes made the whole setup much smoother and got rid of many edge cases. I also didn't encounter any problems. |
@michi-zuri I'm on it, rebasing now. Will merge if all test are green. Thanks for testing this branch. |
2288640
to
042c1b3
Compare
- Recommend having a wrapper direnv function so that people dont have to write asdf exec direnv stuff - Old shim is now part of asdf direnv extension command. - You can have an .envrc with use asdf even if the directory has no .tool-versions file. All asdf current tools will be activated. In alphabetical order, since we only preserve PATH order when a .tool-versions file is present. - Remove all variants of use asdf * have been removed. Doing use asdf will just ask asdf which versions are available in current directory. use asdf local/global were just internal apis and not intended for people to use. use asdf tool version was a bad choice since people should store versions on their .tool-versions file. - Move commands to new asdf `lib/commands/*.bash` location See https://asdf-vm.com/#/plugins-create?id=extension-commands-for-asdf-cli
asdf direnv triggers a dirname error
@michi-zuri merged! be sure to update to latest asdf and also update this plugin. |
This branch has some major changes:
direnv
function so that people dont have to writeasdf exec direnv stuff
asdf direnv
extension command..envrc
withuse asdf
even if the directory has no.tool-versions
file. Allasdf current
tools will be activated. In alphabetical order, since we only preserve PATH order when a.tool-versions
file is present.use asdf *
have been removed.use asdf
will just ask asdf which versions are available in current directory.use asdf local/global
were just internal apis and not intended for people to use.use asdf tool version
was a bad choice since people should store versions on their.tool-versions
file.Still working on tests.
https://github.com/asdf-community/asdf-direnv/blob/direnv_command/README.md
Perhaps we should start creating releases.