Support column widths 2.5.x #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
This PR fixes the issue mentioned in #1265.
Column.setWidth will be honored if an extension calls Table#assignColumnWidths() after setting the column widths and adding the columns to the table (in addition to establishing the parent-child-relationship).
How does it achieve that?
Are there any alternative ways to implement this?
Column widths could be assigned whenever a column is added to a table, or when Column.setWidth is invoked.
This change would be very intrusive though.
Therefore, I found it better to have a way that requires calling a new method.
Are there any implications of this pull request? Anything a user must know?
Not really. Existing code is not touched.
Behavior only changes when a new method is invoked that didn't exist before.
Issue
Fixes #1265