Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update moment-timezone to reduce payload size #3933

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Update moment-timezone to reduce payload size #3933

merged 3 commits into from
Apr 23, 2019

Conversation

zephraph
Copy link
Contributor

Bumps the version of moment-timezone that's now significantly smaller due to a reduced time-range set in latest.json. See moment/moment-timezone#697 for more context.

@artsyit
Copy link
Contributor

artsyit commented Apr 22, 2019 •
edited
Loading

Duplicate Sources / Packages - Duplicates found! ⚠️

Duplicates: Found 32 similar files across 42 code sources (both identical + similar)
accounting for 550244 bundled bytes.
Packages: Found 10 packages with 19 resolved, 22 installed, and 63 depended versions.

Roughly 28 lines removed. This is probably an improvement over master.

Diff of duplicates in this branch vs master 
 Duplicate Sources / Packages - Duplicates found! ⚠️
 
 
-* Duplicates: Found 37 similar files across 51 code sources (both identical + similar)
+* Duplicates: Found 32 similar files across 42 code sources (both identical + similar)
 
 
-  accounting for 3374573 bundled bytes.
+  accounting for 550244 bundled bytes.
 
 
-* Packages: Found 11 packages with 21 resolved, 25 installed, and 66 depended versions.
+* Packages: Found 10 packages with 19 resolved, 22 installed, and 63 depended versions.
 
 
 ## auctions.js
 acorn (Found 2 resolved, 3 installed, 3 depended. Latest 2.7.0.)
   1.2.2
     ~/with/~/acorn
       * Dependency graph
         [email protected] -> jade@^1.11.0 -> with@~4.0.0 -> acorn@^1.0.1
       * Duplicated files in auctions.js
         acorn/dist/acorn.js (S, 131402)
         acorn/dist/walk.js (S, 11791)
 
   2.7.0
     ~/jade/~/acorn
       * Dependency graph
         [email protected] -> jade@^1.11.0 -> constantinople@~3.0.1 -> acorn@^2.1.0
       * Duplicated files in auctions.js
         acorn/dist/acorn.js (I, 119975)
         acorn/dist/walk.js (I, 13326)
 
     ~/with/~/acorn-globals/~/acorn
       * Dependency graph
         [email protected] -> jade@^1.11.0 -> with@~4.0.0 -> acorn-globals@^1.0.3 -> acorn@^2.1.0
       * Duplicated files in auctions.js
         acorn/dist/acorn.js (I, 119975)
         acorn/dist/walk.js (I, 13326)
 
 ## common.js
 assignment (Found 2 resolved, 2 installed, 4 depended. Latest 2.2.0.)
   2.0.0
     ~/insane/~/assignment
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> trunc-html@^1.1.2 -> [email protected] -> [email protected]
         [email protected] -> @artsy/[email protected] -> trunc-html@^1.1.2 -> [email protected] -> [email protected]
       * Duplicated files in common.js
         assignment/assignment.js (S, 508)
 
   2.2.0
     ~/assignment
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> trunc-html@^1.1.2 -> [email protected]
         [email protected] -> @artsy/[email protected] -> trunc-html@^1.1.2 -> [email protected]
       * Duplicated files in common.js
         assignment/assignment.js (S, 696)
 
 bluebird-q (Found 2 resolved, 2 installed, 2 depended. Latest 2.1.1.)
   1.0.3
     ~/artsy-backbone-mixins/~/bluebird-q
       * Dependency graph
         [email protected] -> artsy-backbone-mixins@artsy/artsy-backbone-mixins -> bluebird-q@^1.0.3
       * Duplicated files in common.js
         bluebird-q/index.js (S, 14411)
 
   2.1.1
     ~/bluebird-q
       * Dependency graph
         [email protected] -> bluebird-q@^2.1.1
       * Duplicated files in common.js
         bluebird-q/index.js (S, 16795)
 
 domelementtype (Found 2 resolved, 2 installed, 18 depended. Latest 1.3.0.)
   1.1.3
     ~/dom-serializer/~/domelementtype
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> [email protected] -> dom-serializer@0 -> domelementtype@~1.1.1
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> dom-serializer@~0.1.0 -> domelementtype@~1.1.1
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
         [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
         [email protected] -> cheerio@^0.22.0 -> css-select@~1.2.0 -> [email protected] -> dom-serializer@0 -> domelementtype@~1.1.1
         [email protected] -> cheerio@^0.22.0 -> dom-serializer@~0.1.0 -> domelementtype@~1.1.1
         [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
       * Duplicated files in common.js
         domelementtype/index.js (S, 389)
 
   1.3.0
     ~/domelementtype
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> [email protected] -> domelementtype@1
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domelementtype@^1.3.0
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domhandler@^2.3.0 -> domelementtype@1
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> domelementtype@1
         [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domelementtype@^1.3.0
         [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domhandler@^2.3.0 -> domelementtype@1
         [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1 -> domelementtype@1
         [email protected] -> cheerio@^0.22.0 -> css-select@~1.2.0 -> [email protected] -> domelementtype@1
         [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domelementtype@^1.3.0
         [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domhandler@^2.3.0 -> domelementtype@1
         [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> domelementtype@1
       * Duplicated files in common.js
         domelementtype/index.js (S, 411)
 
 domutils (Found 2 resolved, 2 installed, 5 depended. Latest 1.7.0.)
   1.5.1
     ~/domutils
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> [email protected]
         [email protected] -> cheerio@^0.22.0 -> css-select@~1.2.0 -> [email protected]
       * Duplicated files in common.js
         domutils/index.js (I, 322)
         domutils/lib/helpers.js (I, 3930)
         domutils/lib/legacy.js (I, 2489)
         domutils/lib/manipulation.js (I, 1530)
         domutils/lib/querying.js (S, 1867)
         domutils/lib/stringify.js (S, 607)
         domutils/lib/traversal.js (I, 547)
 
   1.7.0
     ~/htmlparser2/~/domutils
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1
         [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1
         [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1
       * Duplicated files in common.js
         domutils/index.js (I, 322)
         domutils/lib/helpers.js (I, 3930)
         domutils/lib/legacy.js (I, 2489)
         domutils/lib/manipulation.js (I, 1530)
         domutils/lib/querying.js (S, 1893)
         domutils/lib/stringify.js (S, 668)
         domutils/lib/traversal.js (I, 547)
 
 hoist-non-react-statics (Found 1 resolved, 2 installed, 3 depended. Latest 3.1.0.)
   3.1.0
     ~/react-redux/~/hoist-non-react-statics
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> found@^0.3.14 -> react-redux@^5.0.7 -> hoist-non-react-statics@^3.1.0
         [email protected] -> react-redux@^5.0.2 -> hoist-non-react-statics@^3.1.0
       * Duplicated files in common.js
         hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js (I, 2553)
 
     ~/react-tracking/~/hoist-non-react-statics
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> react-tracking@^5.6.0 -> hoist-non-react-statics@^3.0.1
       * Duplicated files in common.js
         hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js (I, 2553)
 
 inherits (Found 2 resolved, 2 installed, 13 depended. Latest 2.0.3.)
   2.0.1
     ~/util/~/inherits
       * Dependency graph
         [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> util@^0.10.3 -> [email protected]
       * Duplicated files in common.js
         inherits/inherits_browser.js (I, 672)
 
   2.0.3
     ~/inherits
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> superagent@^1.2.0 -> readable-stream@^2.3.5 -> inherits@~2.0.3
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> inherits@^2.0.1
         [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> readable-stream@^3.0.6 -> inherits@^2.0.3
         [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> inherits@^2.0.1
         [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> readable-stream@^3.0.6 -> inherits@^2.0.3
         [email protected] -> @artsy/[email protected] -> superagent@^3.6.3 -> readable-stream@^2.3.5 -> inherits@~2.0.3
         [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> inherits@^2.0.1
         [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> readable-stream@^3.0.6 -> inherits@^2.0.3
         [email protected] -> superagent@^3.8.3 -> readable-stream@^2.3.5 -> inherits@~2.0.3
         [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> readable-stream@^2.3.3 -> inherits@~2.0.3
         [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> stream-browserify@^2.0.1 -> inherits@~2.0.1
         [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> stream-browserify@^2.0.1 -> readable-stream@^2.0.2 -> inherits@~2.0.3
       * Duplicated files in common.js
         inherits/inherits_browser.js (I, 672)
 
 isarray (Found 2 resolved, 2 installed, 4 depended. Latest 1.0.0.)
   0.0.1
     ~/isarray
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> found@^0.3.14 -> path-to-regexp@^1.7.0 -> [email protected]
         [email protected] -> @artsy/[email protected] -> react-router@^4.2.0 -> path-to-regexp@^1.7.0 -> [email protected]
         [email protected] -> react-router@^4.2.0 -> path-to-regexp@^1.7.0 -> [email protected]
       * Duplicated files in common.js
         isarray/index.js (S, 120)
 
   1.0.0
     ~/buffer/~/isarray
       * Dependency graph
         [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> buffer@^4.3.0 -> isarray@^1.0.0
       * Duplicated files in common.js
         isarray/index.js (S, 132)
 
 
-moment-timezone (Found 2 resolved, 3 installed, 3 depended. Latest 0.5.25.)
-  0.5.23
-    ~/moment-timezone
-      * Dependency graph
-        [email protected] -> moment-timezone@^0.5.23
-      * Duplicated files in common.js
-        moment-timezone/data/packed/latest.json (S, 925115)
-        moment-timezone/index.js (I, 116)
-        moment-timezone/moment-timezone.js (S, 14996)
-
-  0.5.25
-    ~/@artsy/palette/~/moment-timezone
-      * Dependency graph
-        [email protected] -> @artsy/[email protected] -> moment-timezone@^0.5.25
-      * Duplicated files in common.js
-        moment-timezone/data/packed/latest.json (I, 926653)
-        moment-timezone/index.js (I, 116)
-        moment-timezone/moment-timezone.js (I, 15282)
-
-    ~/@artsy/reaction/~/moment-timezone
-      * Dependency graph
-        [email protected] -> @artsy/[email protected] -> moment-timezone@^0.5.25
-      * Duplicated files in common.js
-        moment-timezone/data/packed/latest.json (I, 926653)
-        moment-timezone/index.js (I, 116)
-        moment-timezone/moment-timezone.js (I, 15282)
-
-
 qs (Found 2 resolved, 2 installed, 6 depended. Latest 6.5.2.)
   5.2.0
     ~/artsy-backbone-mixins/~/qs
       * Dependency graph
         [email protected] -> artsy-backbone-mixins@artsy/artsy-backbone-mixins -> [email protected]
       * Duplicated files in common.js
         qs/lib/index.js (S, 200)
         qs/lib/parse.js (S, 5363)
         qs/lib/stringify.js (S, 3906)
         qs/lib/utils.js (S, 4319)
 
   6.5.2
     ~/qs
       * Dependency graph
         [email protected] -> qs@^6.3.0
         [email protected] -> @artsy/[email protected] -> superagent@^1.2.0 -> qs@^6.5.1
         [email protected] -> @artsy/[email protected] -> qs@^6.5.0
         [email protected] -> @artsy/[email protected] -> superagent@^3.6.3 -> qs@^6.5.1
         [email protected] -> superagent@^3.8.3 -> qs@^6.5.1
       * Duplicated files in common.js
         qs/lib/index.js (S, 211)
         qs/lib/parse.js (S, 5817)
         qs/lib/stringify.js (S, 6288)
         qs/lib/utils.js (S, 5554)
 
 redux (Found 2 resolved, 3 installed, 5 depended. Latest 4.0.1.)
   3.6.0
     ~/redux
       * Dependency graph
         [email protected] -> redux@^3.6.0
       * Duplicated files in common.js
         
 
   4.0.1
     ~/farce/~/redux
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> farce@^0.2.6 -> redux@^4.0.0
         [email protected] -> @artsy/[email protected] -> found-scroll@^0.1.5 -> farce@^0.2.1 -> redux@^4.0.0
         [email protected] -> @artsy/[email protected] -> found@^0.3.14 -> farce@^0.2.6 -> redux@^4.0.0
       * Duplicated files in common.js
         redux/es/redux.js (I, 23104)
 
     ~/found/~/redux
       * Dependency graph
         [email protected] -> @artsy/[email protected] -> found@^0.3.14 -> redux@^4.0.0
       * Duplicated files in common.js
         redux/es/redux.js (I, 23104)
 
 * Understanding the report: Need help with the details? See:
   https://github.com/FormidableLabs/inspectpack/#diagnosing-duplicates
 * Fixing bundle duplicates: An introductory guide:
   https://github.com/FormidableLabs/inspectpack/#fixing-bundle-duplicates

Fixing bundle duplicates | An introductory guide

@dblandin, @zephraph

auctions.js

acorn (Found 2 resolved, 3 installed, 3 depended. Latest 2.7.0.) 
1.2.2
  ~/with/~/acorn
    * Dependency graph
      [email protected] -> jade@^1.11.0 -> with@~4.0.0 -> acorn@^1.0.1
    * Duplicated files in auctions.js
      acorn/dist/acorn.js (S, 131402)
      acorn/dist/walk.js (S, 11791)
2.7.0
  ~/jade/~/acorn
    * Dependency graph
      [email protected] -> jade@^1.11.0 -> constantinople@~3.0.1 -> acorn@^2.1.0
    * Duplicated files in auctions.js
      acorn/dist/acorn.js (I, 119975)
      acorn/dist/walk.js (I, 13326)
  ~/with/~/acorn-globals/~/acorn
    * Dependency graph
      [email protected] -> jade@^1.11.0 -> with@~4.0.0 -> acorn-globals@^1.0.3 -> acorn@^2.1.0
    * Duplicated files in auctions.js
      acorn/dist/acorn.js (I, 119975)
      acorn/dist/walk.js (I, 13326)

common.js

assignment (Found 2 resolved, 2 installed, 4 depended. Latest 2.2.0.) 
2.0.0
  ~/insane/~/assignment
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> trunc-html@^1.1.2 -> [email protected] -> [email protected]
      [email protected] -> @artsy/[email protected] -> trunc-html@^1.1.2 -> [email protected] -> [email protected]
    * Duplicated files in common.js
      assignment/assignment.js (S, 508)
2.2.0
  ~/assignment
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> trunc-html@^1.1.2 -> [email protected]
      [email protected] -> @artsy/[email protected] -> trunc-html@^1.1.2 -> [email protected]
    * Duplicated files in common.js
      assignment/assignment.js (S, 696)
bluebird-q (Found 2 resolved, 2 installed, 2 depended. Latest 2.1.1.) 
1.0.3
  ~/artsy-backbone-mixins/~/bluebird-q
    * Dependency graph
      [email protected] -> artsy-backbone-mixins@artsy/artsy-backbone-mixins -> bluebird-q@^1.0.3
    * Duplicated files in common.js
      bluebird-q/index.js (S, 14411)
2.1.1
  ~/bluebird-q
    * Dependency graph
      [email protected] -> bluebird-q@^2.1.1
    * Duplicated files in common.js
      bluebird-q/index.js (S, 16795)
domelementtype (Found 2 resolved, 2 installed, 18 depended. Latest 1.3.0.) 
1.1.3
  ~/dom-serializer/~/domelementtype
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> [email protected] -> dom-serializer@0 -> domelementtype@~1.1.1
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> dom-serializer@~0.1.0 -> domelementtype@~1.1.1
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
      [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
      [email protected] -> cheerio@^0.22.0 -> css-select@~1.2.0 -> [email protected] -> dom-serializer@0 -> domelementtype@~1.1.1
      [email protected] -> cheerio@^0.22.0 -> dom-serializer@~0.1.0 -> domelementtype@~1.1.1
      [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
    * Duplicated files in common.js
      domelementtype/index.js (S, 389)
1.3.0
  ~/domelementtype
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> [email protected] -> domelementtype@1
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domelementtype@^1.3.0
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domhandler@^2.3.0 -> domelementtype@1
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> domelementtype@1
      [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domelementtype@^1.3.0
      [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domhandler@^2.3.0 -> domelementtype@1
      [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1 -> domelementtype@1
      [email protected] -> cheerio@^0.22.0 -> css-select@~1.2.0 -> [email protected] -> domelementtype@1
      [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domelementtype@^1.3.0
      [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domhandler@^2.3.0 -> domelementtype@1
      [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> domelementtype@1
    * Duplicated files in common.js
      domelementtype/index.js (S, 411)
domutils (Found 2 resolved, 2 installed, 5 depended. Latest 1.7.0.) 
1.5.1
  ~/domutils
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> [email protected]
      [email protected] -> cheerio@^0.22.0 -> css-select@~1.2.0 -> [email protected]
    * Duplicated files in common.js
      domutils/index.js (I, 322)
      domutils/lib/helpers.js (I, 3930)
      domutils/lib/legacy.js (I, 2489)
      domutils/lib/manipulation.js (I, 1530)
      domutils/lib/querying.js (S, 1867)
      domutils/lib/stringify.js (S, 607)
      domutils/lib/traversal.js (I, 547)
1.7.0
  ~/htmlparser2/~/domutils
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1
      [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1
      [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1
    * Duplicated files in common.js
      domutils/index.js (I, 322)
      domutils/lib/helpers.js (I, 3930)
      domutils/lib/legacy.js (I, 2489)
      domutils/lib/manipulation.js (I, 1530)
      domutils/lib/querying.js (S, 1893)
      domutils/lib/stringify.js (S, 668)
      domutils/lib/traversal.js (I, 547)
hoist-non-react-statics (Found 1 resolved, 2 installed, 3 depended. Latest 3.1.0.) 
3.1.0
  ~/react-redux/~/hoist-non-react-statics
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> found@^0.3.14 -> react-redux@^5.0.7 -> hoist-non-react-statics@^3.1.0
      [email protected] -> react-redux@^5.0.2 -> hoist-non-react-statics@^3.1.0
    * Duplicated files in common.js
      hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js (I, 2553)
  ~/react-tracking/~/hoist-non-react-statics
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> react-tracking@^5.6.0 -> hoist-non-react-statics@^3.0.1
    * Duplicated files in common.js
      hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js (I, 2553)
inherits (Found 2 resolved, 2 installed, 13 depended. Latest 2.0.3.) 
2.0.1
  ~/util/~/inherits
    * Dependency graph
      [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> util@^0.10.3 -> [email protected]
    * Duplicated files in common.js
      inherits/inherits_browser.js (I, 672)
2.0.3
  ~/inherits
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> superagent@^1.2.0 -> readable-stream@^2.3.5 -> inherits@~2.0.3
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> inherits@^2.0.1
      [email protected] -> @artsy/[email protected] -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> readable-stream@^3.0.6 -> inherits@^2.0.3
      [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> inherits@^2.0.1
      [email protected] -> @artsy/[email protected] -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> readable-stream@^3.0.6 -> inherits@^2.0.3
      [email protected] -> @artsy/[email protected] -> superagent@^3.6.3 -> readable-stream@^2.3.5 -> inherits@~2.0.3
      [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> inherits@^2.0.1
      [email protected] -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> readable-stream@^3.0.6 -> inherits@^2.0.3
      [email protected] -> superagent@^3.8.3 -> readable-stream@^2.3.5 -> inherits@~2.0.3
      [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> readable-stream@^2.3.3 -> inherits@~2.0.3
      [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> stream-browserify@^2.0.1 -> inherits@~2.0.1
      [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> stream-browserify@^2.0.1 -> readable-stream@^2.0.2 -> inherits@~2.0.3
    * Duplicated files in common.js
      inherits/inherits_browser.js (I, 672)
isarray (Found 2 resolved, 2 installed, 4 depended. Latest 1.0.0.) 
0.0.1
  ~/isarray
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> found@^0.3.14 -> path-to-regexp@^1.7.0 -> [email protected]
      [email protected] -> @artsy/[email protected] -> react-router@^4.2.0 -> path-to-regexp@^1.7.0 -> [email protected]
      [email protected] -> react-router@^4.2.0 -> path-to-regexp@^1.7.0 -> [email protected]
    * Duplicated files in common.js
      isarray/index.js (S, 120)
1.0.0
  ~/buffer/~/isarray
    * Dependency graph
      [email protected] -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> buffer@^4.3.0 -> isarray@^1.0.0
    * Duplicated files in common.js
      isarray/index.js (S, 132)
qs (Found 2 resolved, 2 installed, 6 depended. Latest 6.5.2.) 
5.2.0
  ~/artsy-backbone-mixins/~/qs
    * Dependency graph
      [email protected] -> artsy-backbone-mixins@artsy/artsy-backbone-mixins -> [email protected]
    * Duplicated files in common.js
      qs/lib/index.js (S, 200)
      qs/lib/parse.js (S, 5363)
      qs/lib/stringify.js (S, 3906)
      qs/lib/utils.js (S, 4319)
6.5.2
  ~/qs
    * Dependency graph
      [email protected] -> qs@^6.3.0
      [email protected] -> @artsy/[email protected] -> superagent@^1.2.0 -> qs@^6.5.1
      [email protected] -> @artsy/[email protected] -> qs@^6.5.0
      [email protected] -> @artsy/[email protected] -> superagent@^3.6.3 -> qs@^6.5.1
      [email protected] -> superagent@^3.8.3 -> qs@^6.5.1
    * Duplicated files in common.js
      qs/lib/index.js (S, 211)
      qs/lib/parse.js (S, 5817)
      qs/lib/stringify.js (S, 6288)
      qs/lib/utils.js (S, 5554)
redux (Found 2 resolved, 3 installed, 5 depended. Latest 4.0.1.) 
3.6.0
  ~/redux
    * Dependency graph
      [email protected] -> redux@^3.6.0
    * Duplicated files in common.js
      
4.0.1
  ~/farce/~/redux
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> farce@^0.2.6 -> redux@^4.0.0
      [email protected] -> @artsy/[email protected] -> found-scroll@^0.1.5 -> farce@^0.2.1 -> redux@^4.0.0
      [email protected] -> @artsy/[email protected] -> found@^0.3.14 -> farce@^0.2.6 -> redux@^4.0.0
    * Duplicated files in common.js
      redux/es/redux.js (I, 23104)
  ~/found/~/redux
    * Dependency graph
      [email protected] -> @artsy/[email protected] -> found@^0.3.14 -> redux@^4.0.0
    * Duplicated files in common.js
      redux/es/redux.js (I, 23104)

dblandin
dblandin reviewed Apr 22, 2019
View reviewed changes
Copy link
Member

@dblandin dblandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! Looks like there are some duplicate sources (including moment-timezone) and some failing tests to address before this is ready to merge in.

@zephraph zephraph changed the title Update moment-timezone to reduce payload size [WIP] Update moment-timezone to reduce payload size Apr 22, 2019
@peril-staging
Copy link
Contributor

peril-staging bot commented Apr 23, 2019

Warnings
⚠️

Changes were made to package.json, but not to yarn.lock.
Perhaps you need to run yarn install?

Generated by 🚫 dangerJS against a9d8c6a

@zephraph zephraph changed the title [WIP] Update moment-timezone to reduce payload size Update moment-timezone to reduce payload size Apr 23, 2019
@dblandin
Copy link
Member

Changes were made to package.json, but not to yarn.lock. Perhaps you need to run yarn install?

That Peril warning above looks legit. Are you expecting a yarn.lock change?

@zephraph
Copy link
Contributor Author

Good catch!

dblandin
dblandin approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@dblandin dblandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge on green 🍏

@peril-staging peril-staging bot merged commit 8961224 into master Apr 23, 2019
@zephraph zephraph deleted the update-moment-timezone branch April 23, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblandin dblandin dblandin approved these changes

Assignees

@dblandin dblandin

Labels
Merge On Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zephraph @artsyit @dblandin