Allow Faraday 2.x #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraday split all of the different adapters out into separate gems and pulled some common middleware into the main gem. This allows anyone using the Gem to also use Faraday 2.x. https://github.com/lostisland/faraday/blob/main/CHANGELOG.md Closes arthurnn#84
|
Just adding a +1 for this. 😃 |
|
Also a strong +1! Hopefully @wmatveyenko takes a look soon since they seem to be active in here 😸 |
|
👍 lets go ahead with this. We are also at the process of upgrading Faraday at GitHub, and relaxing this will help us too. thanks |
|
@gaffneyc can you add this - "By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license." to you PR? Thanks! |
|
Sure thing, added it to the PR message. Thank you for getting these merged |
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faraday split all of the different adapters out into separate gems and
pulled some common middleware into the main gem. This allows anyone
using the Gem to also use Faraday 2.x.
Quick note that I didn't change Gemfile.lock as I hope that #86 or #87 are merged before this. Tests are all green on Faraday 2.3.
https://github.com/lostisland/faraday/blob/main/CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Closes #84