Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable strict mode for JSON Client. #63

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

alusco-scratch
Copy link
Contributor

@alusco-scratch alusco-scratch commented Nov 24, 2020

A PR a while back added strict JSON vs non-strict JSON encoding.
This adds a flag to JSON client to enable that strict mode which can be
useful when doing testing.

A PR added a while back to add a strict JSON vs non-strict JSON mode.
This adds a flag to JSON client to enable strict mode which can be
useful when doing testing.
Copy link
Collaborator

@marioizquierdo marioizquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely.
It makes sense, because ClientJSON is meant for manual debugging (vs Client.new(conn, content_type: "application/json") that is meant for usage in production).
Thank you!

@marioizquierdo marioizquierdo merged commit 3065841 into arthurnn:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants