Support Rack 3 #124
Merged
Support Rack 3 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headers must all be lowercase. See: https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#response-headers-must-be-lower-case Leverage Rack::Headers to help enforce this, falling back to a normal Hash in Rack 2.
Rack 3 no longer requires us to rewind the body. Rather than drop it, we still rewind if we can.
It references the hello_world code from the regular example to show that there are no changes needed.
Keeps them consistent under Rack 2 and 3.
|
@arthurnn our team could use this update as well. Hoping it gets merged in! |
|
thanks for working on this. this is great. I would be nice to have CI running on rack 2 and 3 too (like we have a matrix for faraday) |
|
@arthurnn added. |
|
👋 @arthurnn Our team is facing a vulnerability issue that could benefit from this update as well! Anything else needed to get this over the finish line? |
|
thanks for working on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Serviceto properly support Rack 3.Looks like this is all we need to do.
rewindif it is rewindable. Apps can addRack::RewindableInput::Middlewareif they need rewindable input.Rack::Headersas recommended (when available) to help ensure headers are lower case.example_rack2that locks to Rack 2, but uses the code from the regular example.Closes #111