Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Best-effort basis: Support building for Windows #15405

Closed
ariya opened this issue Dec 31, 2019 · 8 comments
Closed

Best-effort basis: Support building for Windows #15405

ariya opened this issue Dec 31, 2019 · 8 comments
Assignees

Comments

@ariya
Copy link
Owner

ariya commented Dec 31, 2019

Although the current priority is to focus on Linux (#15398), there is no harm in making sure that building for Windows is supported or partially supported, with no 100% guarantee.
At least, this serves as a good stepping stone for any external contribution.

@ariya ariya added the build label Dec 31, 2019
@ariya
Copy link
Owner Author

ariya commented Dec 31, 2019

The good news: the community QtWebKit 5.212 is available as MinGW package for MSYS2.

@ariya
Copy link
Owner Author

ariya commented Dec 31, 2019

The bad news: the package seems to currently broken (see msys2/MINGW-packages#5934 or msys2/MINGW-packages#6020), perhaps even due to a new GCC.

ariya added a commit that referenced this issue Jan 4, 2020
ariya added a commit that referenced this issue Jan 7, 2020
Currently it is disabled, due to broken QtWebKit on MinGW/MSYS2
(see #15405 for details)
@vitallium vitallium self-assigned this Jan 13, 2020
@stale stale bot added the stale label Feb 12, 2020
@ariya ariya removed the stale label Feb 19, 2020
@annulen
Copy link

annulen commented Feb 29, 2020

It's possible to build static Conan packages of QtWebKit (all dependencies are already packaged) and use them for building of binaries of PhantomJS for all platforms in some CI service. The only trouble is building QtWebKit, of course, but GitHub Actions should be able to manage that

@safrizal
Copy link

tapi saya disuruh harus pakai ini :
cmake . -G "MSYS Makefiles",
bukan ini :
cmake . -G "MinGW Makefiles"

@annulen
Copy link

annulen commented Mar 23, 2020

"MSYS Makefiles" should be used when running in MSYS shell, "MinGW Makefiles" - when using cmd.exe and mingw32-make

@stale stale bot added the stale label Apr 22, 2020
@stale
Copy link

stale bot commented May 7, 2020

Due to our very limited maintenance capacity, we need to prioritize our development focus on other tasks. Therefore, this issue will be automatically closed (see #15395 for more details). In the future, if we see the need to attend to this issue again, then it will be reopened. Thank you for your contribution!

@ariya
Copy link
Owner Author

ariya commented Jun 2, 2020

Thanks to the combination of MSYS2, updated qtwebkit package for MSYS2, GCC and Clang, as well as the infrastructure of GitHub Actions, finally we have the CI system running the build of the latest master branch on Windows, for both GCC and Clang!

image

Check the log for more details: https://github.com/ariya/phantomjs/actions.

Currently Windows build with MSYS2 is bit longer, around 7 minutes, compared to the Linux build (typically finishes in 2 minutes) because of the need to install various packages through Pacman. We'll find some ways to cache those packages and to optimized the bulild time.

imgbot bot pushed a commit to kiss2u/phantomjs that referenced this issue Apr 19, 2021
@SuperPat45
Copy link

I try to compile the master branch, but the executable I obtain is compiled with shared library linkage mode.

How can I compile in static library linkage mode, allowing redistribution of a single executable without any dependancy ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants