Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Check and enforce C++ coding style #15404

Closed
ariya opened this issue Dec 29, 2019 · 6 comments
Closed

Check and enforce C++ coding style #15404

ariya opened this issue Dec 29, 2019 · 6 comments
Assignees
@ariya
Labels
build

Comments

@ariya
Copy link
Owner

ariya commented Dec 29, 2019

Use clang-format to ensure consistent C++ coding style.

Let's also run this as part of the CI system (#15403) so that PR can be checked for coding style consistency.
@ariya ariya self-assigned this Dec 29, 2019
@HouzuoGuo
Copy link

@ariya Welcome back to PhantomJS! Thanks for resuming its development, looking forward to the first phantomjs 3 release :)

@ariya ariya removed the pinned label Dec 31, 2019
@vitallium
Copy link
Collaborator

@ariya Qt's coding style may I assume?

@vitallium
Copy link
Collaborator

vitallium commented Jan 3, 2020 •
edited by ariya
Loading

@ariya
Copy link
Owner Author

ariya commented Jan 7, 2020

@ariya Qt's coding style may I assume?

IMO we might as well use (the built-in) WebKit style, hence no further tweak is necessary.

ariya added a commit that referenced this issue Jan 8, 2020
@ariya
Format the code using clang-format (#15404)
699510f 
clang-format -i --style=WebKit src/*.h src/*.cpp
ariya added a commit that referenced this issue Jan 8, 2020
@ariya
CI to check for coding style (#15404)
be71ec2
@ariya
Copy link
Owner Author

ariya commented Jan 8, 2020

This is now in effect, yay!

@ariya ariya closed this as completed Jan 8, 2020
@alex-kovalchuk
Copy link

Thank you!!!

ariya added a commit that referenced this issue Jun 2, 2020
@ariya
Use clang-format 6.0 to check for code style (#15403, #15404)
6efc102 
This way, the CI can run on the faster and more common Ubuntu machine.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ariya ariya

Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ariya @HouzuoGuo @vitallium @alex-kovalchuk