Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Use SemaphoreCI to check pull requests #13850

Closed
ariya opened this issue Jan 2, 2016 · 3 comments
Closed

Use SemaphoreCI to check pull requests #13850

ariya opened this issue Jan 2, 2016 · 3 comments
Assignees

Comments

@ariya
Copy link
Owner

ariya commented Jan 2, 2016

While we are still searching for an ideal continuous build system (#13828), it was discovered that SemaphoreCI might be sufficient to run a build and the test suite for a feature branch in a pull request. It will be limited to 64-bit Linux, but it's better than nothing.

This issue is to track and note the progress of implementing pull request check using SemaphoreCI.

@ariya ariya self-assigned this Jan 2, 2016
@Vanuan
Copy link

Vanuan commented Jan 5, 2016

Isn't this trivial?
As you see here, pull requests are built automatically:
Vanuan#1

@ariya
Copy link
Owner Author

ariya commented Jan 5, 2016

Trivial or not, this is a placeholder to document any possible issues. If there is no issue, then it's fine. But it's always better to have it documented for future reference and/or search.

ariya added a commit that referenced this issue Jan 24, 2016
Historically this has been failing forever and we plan to switch to
a different setup.

Refs #13850
igorshapiro pushed a commit to WiserSolutions/phantomjs that referenced this issue Sep 29, 2016
Historically this has been failing forever and we plan to switch to
a different setup.

Refs ariya#13850
@ghost ghost removed the Build system label Jan 10, 2018
@ariya
Copy link
Owner Author

ariya commented Dec 31, 2019

Obsoleted by #15403.

@ariya ariya closed this as completed Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants