feat: use MkdirAll by OS(#19301)

commitserver/commit/default_mkdir_provider.go

@@ -0,0 +1,22 @@
+//go:build !linux
+
+package commit
+
+import (
+	"fmt"
+	"os"
+
+	securejoin "github.com/cyphar/filepath-securejoin"
+)
+
+func SecureMkdirAll(root, unsafePath string, mode os.FileMode) (string, error) {
+	fullPath, err := securejoin.SecureJoin(root, unsafePath)
+	if err != nil {
+		return "", fmt.Errorf("failed to construct secure path: %w", err)
+	}
+	err = os.MkdirAll(fullPath, mode)
+	if err != nil {
+		return "", fmt.Errorf("failed to create directory: %w", err)
+	}
+	return fullPath, nil
+}

commitserver/commit/default_mkdir_provider_test.go

@@ -0,0 +1,23 @@
+//go:build !linux
+
+package commit
+
+import (
+	"os"
+	"path"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestSecureMkdirAllDefault(t *testing.T) {
+	root := t.TempDir()
+
+	unsafePath := "test/dir"
+	fullPath, err := SecureMkdirAll(root, unsafePath, os.ModePerm)
+	require.NoError(t, err)
+
+	expectedPath := path.Join(root, unsafePath)
+	assert.Equal(t, expectedPath, fullPath)
+}

commitserver/commit/hydratorhelper.go

@@ -8,7 +8,6 @@ import (
 	"path"
 	"text/template"
 
-	securejoin "github.com/cyphar/filepath-securejoin"
 	log "github.com/sirupsen/logrus"
 	"gopkg.in/yaml.v3"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
@@ -30,13 +29,9 @@ func WriteForPaths(rootPath string, repoUrl string, drySha string, paths []*apic
 		if hydratePath == "." {
 			hydratePath = ""
 		}
+
 		var fullHydratePath string
-		fullHydratePath, err = securejoin.SecureJoin(rootPath, hydratePath)
-		if err != nil {
-			return fmt.Errorf("failed to construct hydrate path: %w", err)
-		}
-		// TODO: consider switching to securejoin.MkdirAll: https://github.com/cyphar/filepath-securejoin?tab=readme-ov-file#mkdirall
-		err = os.MkdirAll(fullHydratePath, os.ModePerm)
+		fullHydratePath, err = SecureMkdirAll(rootPath, hydratePath, os.ModePerm)
 		if err != nil {
 			return fmt.Errorf("failed to create path: %w", err)
 		}

commitserver/commit/linux_mkdir_provider.go

@@ -0,0 +1,21 @@
+//go:build linux
+
+package commit
+
+import (
+	"fmt"
+
+	"github.com/cyphar/filepath-securejoin"
+)
+
+func SecureMkdirAll(root, unsafePath string, mode os.FileMode) (string, error) {
+	err := securejoin.MkdirAll(root, unsafePath, mode)
+	if err != nil {
+		return "", fmt.Errorf("failed to make directory: %w", err)
+	}
+	fullPath, err := securejoin.SecureJoin(root, unsafePath)
+	if err != nil {
+		return "", fmt.Errorf("failed to construct secure path: %w", err)
+	}
+	return fullPath, nil
+}

commitserver/commit/linux_mkdir_provider_test.go

@@ -0,0 +1,21 @@
+//go:build linux
+
+package commit
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestSecureMkdirAllLinux(t *testing.T) {
+	root := t.TempDir()
+
+	unsafePath := "test/dir"
+	fullPath, err := SecureMkdirAll(root, unsafePath, os.ModePerm)
+	require.NoError(t, err)
+
+	expectedPath := path.Join(root, unsafePath)
+	require.Equal(t, expectedPath, fullPath)
+}