code-refactoring: setup 0.8.0 #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
force-pushed
the
redesign-setup-0.8
branch
from
7ea5c38 to
64aef41
Compare
jaideepr97
reviewed
Sep 14, 2023
| name: argocd-operator-controller-manager-metrics-service | ||
| spec: | ||
| ports: | ||
| - name: https | ||
| port: 8443 | ||
| targetPort: https | ||
| selector: | ||
| control-plane: argocd-operator | ||
| control-plane: controller-manager |
There was a problem hiding this comment.
@svghadi is this an intentional change? for the 0.7 bundle?
There was a problem hiding this comment.
I cherry-picked the changes from #966.
According to #966 (comment) looks like a intentional change.
jaideepr97
approved these changes
Sep 14, 2023
jaideepr97
merged commit b529e86
into
argoproj-labs:operator-redesign
2 of 3 checks passed
Julik24
pushed a commit
to Julik24/argocd-operator
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Siddhesh Ghadi <[email protected]> Co-authored-by: Regina Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What does this PR do / why we need it:
cherry-pick #966 to refactoring branch to set it up for 0.8