Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-refactoring: add status reconciliation to ArgoCDReconciler #1211

Merged
merged 47 commits into from
Feb 1, 2024

add status reconciliation fns for all components, reconcile statuses …

3325406
Select commit
Loading
Failed to load commit list.
Merged

code-refactoring: add status reconciliation to ArgoCDReconciler #1211

add status reconciliation fns for all components, reconcile statuses …
3325406
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Feb 1, 2024 in 1s

DCO

There are 26 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~47 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin op-red-status

Summary

Commit sha: e49612a, Author: Abhishek Veeramalla, Committer: GitHub; Can not find "Abhishek Veeramalla [email protected]", in ["iam-veeramalla [email protected]", "iam-veeramalla [email protected]", "iam-veeramalla [email protected]", "iam-veeramalla [email protected]"].
Commit sha: 91bf131, Author: Abhishek Veeramalla, Committer: GitHub; Expected "Abhishek Veeramalla [email protected]", but got "iam-veeramalla [email protected]".
Commit sha: 75d6cf4, Author: Abhishek Veeramalla, Committer: GitHub; Can not find "Abhishek Veeramalla [email protected]", in ["iam-veeramalla [email protected]", "iam-veeramalla [email protected]", "iam-veeramalla [email protected]"].
Commit sha: a78a842, Author: Abhishek Veeramalla, Committer: GitHub; Can not find "Abhishek Veeramalla [email protected]", in ["iam-veeramalla [email protected]", "iam-veeramalla [email protected]", "iam-veeramalla [email protected]"].
Commit sha: 962f30f, Author: Cheng Fang, Committer: GitHub; The sign-off is missing.
Commit sha: d424ebd, Author: Isaac Gentz, Committer: GitHub; Expected "Isaac Gentz [email protected]", but got "ikegentz [email protected]".
Commit sha: f2f9fb4, Author: Ishita Sequeira, Committer: GitHub; Can not find "Ishita Sequeira [email protected]", in ["ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]"].
Commit sha: 297702f, Author: Ishita Sequeira, Committer: GitHub; Can not find "Ishita Sequeira [email protected]", in ["ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]"].
Commit sha: 9a294a2, Author: Ishita Sequeira, Committer: GitHub; Can not find "Ishita Sequeira [email protected]", in ["ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]"].
Commit sha: c238af6, Author: Ishita Sequeira, Committer: GitHub; Can not find "Ishita Sequeira [email protected]", in ["ishitasequeira [email protected]", "Raghavi Shirur [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "Raghavi Shirur [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "Raghavi Shirur [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "Raghavi Shirur [email protected]", "ishitasequeira [email protected]", "Raghavi Shirur [email protected]", "ishitasequeira [email protected]", "Raghavi Shirur [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "ishitasequeira [email protected]", "Raghavi Shirur [email protected]"].
Commit sha: 5166a46, Author: Ishita Sequeira, Committer: GitHub; Can not find "Ishita Sequeira [email protected]", in ["ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]", "ishitasequeira [email protected]"].
Commit sha: acee651, Author: Mangaal, Committer: GitHub; Expected "Mangaal [email protected]", but got "Mangaal [email protected]".
Commit sha: 5a2e6c4, Author: Raghavi, Committer: GitHub; Can not find "Raghavi [email protected]", in ["Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Ishita Sequeira [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Raghavi Shirur [email protected]", "Ishita Sequeira [email protected]"].
Commit sha: 4d09aca, Author: Regina Scott, Committer: GitHub; The sign-off is missing.
Commit sha: 89825db, Author: Regina Scott, Committer: GitHub; The sign-off is missing.
Commit sha: 11299b7, Author: Regina Scott, Committer: GitHub; The sign-off is missing.
Commit sha: 000c4a7, Author: Robert Deusser, Committer: GitHub; Can not find "Robert Deusser [email protected]", in ["Robert Deusser [email protected]", "Robert Deusser [email protected]", "Robert Deusser [email protected]", "Robert Deusser [email protected]", "Robert Deusser [email protected]", "Robert Deusser [email protected]"].
Commit sha: 45f3597, Author: Salem Elrahal, Committer: GitHub; Expected "Salem Elrahal [email protected]", but got "Salem Elrahal [email protected]".
Commit sha: b25858d, Author: Siddhesh Ghadi, Committer: GitHub; Can not find "Siddhesh Ghadi [email protected]", in ["Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]"].
Commit sha: e624a26, Author: Siddhesh Ghadi, Committer: GitHub; Can not find "Siddhesh Ghadi [email protected]", in ["Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]"].
Commit sha: e928c0e, Author: Siddhesh Ghadi, Committer: GitHub; Expected "Siddhesh Ghadi [email protected]", but got "Siddhesh Ghadi [email protected]".
Commit sha: 380207e, Author: Siddhesh Ghadi, Committer: GitHub; Can not find "Siddhesh Ghadi [email protected]", in ["Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]"].
Commit sha: 8ddbce3, Author: Siddhesh Ghadi, Committer: GitHub; Can not find "Siddhesh Ghadi [email protected]", in ["Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]", "Siddhesh Ghadi [email protected]"].
Commit sha: fb27066, Author: Siddhesh Ghadi, Committer: GitHub; Expected "Siddhesh Ghadi [email protected]", but got "Siddhesh Ghadi [email protected]".
Commit sha: 3c80cd2, Author: Siddhesh Ghadi, Committer: GitHub; Expected "Siddhesh Ghadi [email protected]", but got "Siddhesh Ghadi [email protected]".
Commit sha: aa6ab4e, Author: Suraj yadav, Committer: GitHub; Can not find "Suraj yadav [email protected]", in ["Surajyadav [email protected]", "Surajyadav [email protected]", "Surajyadav [email protected]", "Surajyadav [email protected]", "Surajyadav [email protected]"].