-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow enabling ArgoCD workloads independently #1021
Merged
anandf
merged 13 commits into
argoproj-labs:master
from
ishitasequeira:independent-argocd-workload-enabling
Nov 16, 2023
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6b0b745
allow enabling ArgoCD core workloads independently
ishitasequeira e39f601
fix lint
ishitasequeira a9a0712
check for dependent component urls if dependent components are disabled
ishitasequeira 28c10f4
fix build
ishitasequeira ec64419
fix make bundle
ishitasequeira 5bc2e5c
fix tests
ishitasequeira bb299c8
Update flags for each component
ishitasequeira 5449b28
Update configuration using remote flag
ishitasequeira addf5da
fix CI
ishitasequeira dea754c
Address comments
ishitasequeira 5d714b4
Addressed feedback
ishitasequeira ebbe434
update conversion webhook
ishitasequeira 8aec351
fix make build
ishitasequeira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unnecessary for appset, since we can already enable/disable appset by leaving it as nil or not nil
is there some way this field will become useful in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried keeping it consistent with the format being used for other core components of ArgoCD. It would be better to update that behavior eventually as ApplicationSet is considered a core component for ArgoCD now.