Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nall: Linux does support file creation time #1117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffythedragonslayer
Copy link
Contributor

I saw Screwtape mention this as part of a good first issue somewhere, thanks for pointing that out about statx

@Screwtapello
Copy link
Contributor

This PR has a change to the comment, but doesn't actually try to call statx(). Was that deliberate, or did you forget to push a commit?

@jeffythedragonslayer
Copy link
Contributor Author

Yes it was deliberate, I haven't delved deep into the codebase yet to actually fix the call. Just trying to stop people who are browsing the codebase from getting wrong information into their heads for now.

@LukeUsher
Copy link
Member

Please consider adding an implementation that uses statx; it seems odd to merge a commit that makes reference to another possibility without providing it.

@flagrama
Copy link

This also does depend on what you want the minimum required Linux kernel version for the emulator to be. statx was introduced in the 4.11 Linux kernel, which is now over 6 years old so is probably needs suiting for most people, but may effectively increase the minimum kernel version, and the implementation of this might need to keep that in mind.

In fact mentioning a minimum Linux kernel version/maximum Linux kernel age the emulator wants to support might be nice to have in the README for situations like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants