Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recode powerwall #22589

Merged
merged 1 commit into from
Dec 5, 2024
Merged

recode powerwall #22589

merged 1 commit into from
Dec 5, 2024

Conversation

gemu2015
Copy link
Contributor

@gemu2015 gemu2015 commented Dec 5, 2024

Description:

recode tesla powerwall function
some bugfixes

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241117
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 9317e02 into arendst:development Dec 5, 2024
59 checks passed
@gemu2015 gemu2015 deleted the powerwall branch December 5, 2024 14:44
eku
eku reviewed Dec 7, 2024
View reviewed changes
tasmota/include/Powerwall.h
dlen = ssl_client.available();
AddLog(PWL_LOGLVL, PSTR("PWL: available: %d"), dlen);
String response = "";
#if 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eku eku eku left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gemu2015 @eku @arendst