Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Connected Fields values Array support #935

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Fix for Connected Fields values Array support #935

merged 3 commits into from
Jun 2, 2021

Conversation

baccadiginepro
Copy link
Contributor

@baccadiginepro baccadiginepro commented May 25, 2021 •
edited
Loading

Description

This PR fixes a bug where a value of type Array passed to requiredFieldValues prop results in unexpected behavior. Only single values work for this property.

@component('twill::partials.form.utils._connected_fields', [
    'fieldName' => 'input_type',
    'fieldValues' => ["radio","select"],
    'renderForBlocks' => true
])

Related Issues

Fixes #788

@CLAassistant
Copy link

CLAassistant commented May 25, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ifox
ifox previously approved these changes May 25, 2021
View reviewed changes
@ifox
Copy link
Member

ifox commented May 25, 2021

/rebase

@ifox
Copy link
Member

ifox commented May 25, 2021

/build-frontend

@ifox ifox merged commit d928c5e into area17:2.x Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifox ifox ifox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing Array to Connected Fields form fields does not work
3 participants
@baccadiginepro @CLAassistant @ifox