Artisan make:module (deprecated) should prompt for input #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ifox
force-pushed
the
fix/module-command-features
branch
from
54389cf to
f64c645
Compare
ifox
previously approved these changes
Mar 26, 2021
|
/rebase |
ifox
force-pushed
the
fix/module-command-features
branch
from
f64c645 to
56702b2
Compare
ifox
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in Laravel when passing
options()programatically where if theno-interactionoption is present in the ArrayInput, the framework will run the command as no-interaction. I have created a PR for it here: #33950. This presents an issue with theartisan twill:moduledeprecated command as no matter what features you would like included with the module, it will enable all of them as if it was default. No prompts are shown.As per the current documentation, it is advised to use
artisan twill:modulerather thanartisan twill:make:modulewhich is the latest and working command. Regardless, this PR should act as a workaround for the issue.With this PR, the prompts should now show for the user to confirm which features they would like in their new module.