Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It looks like using a
medias
field with the configuration keytwill.media_library.translated_form_fields = true
in the settings doesn't work at all.I've fixed two issues to allow medias in settings to be localized.
image[en]
would be translated tomedias[image[en]][0]
which doesn't work. My fix changes it to a workingmedias[image][en][0]
.I don't know if there is any side effects to this changes but I think not. I've tried every instance of this component on my relatively small website and everything works as intented.
twill.media_library.translated_form_fields
configuration key is set to true.These changes would probably break the translated medias on websites with the twill.media_library.translated_form_fields activated but like I said it doesn't work at all at the moment so it shouldn't be much of an issue.