Add Laravel 7 support #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For anyone checking this out, we're going to release 2.0 today without it until the Glide Laravel wrapper is compatible (or we will depend on Glide directly if there's no progress there this week), which means Laravel 7 support will be released in Twill 2.1 as soon as this PR is ready. |
|
@reinink saves the day, Glide is now Laravel 7 compatible 🙌 |
Using kalnoy/nestedset pending support PR for now: lazychaser/laravel-nestedset#441
This reverts commit bcfc688.
This reverts commit 75175c6.
…nd let developers deal with error views, providing a quick helper for backward compat
ifox
added a commit
that referenced
this pull request
Mar 31, 2020
With the simplification of the exception handler in #561 the override of the invalidJson method was dropped by mistake. It is currently necessary as the frontend expects errors only in a validation exception response. In future improvments it would be better to keep the default Laravel response format and update the frontend to read one level deeper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using kalnoy/nestedset pending support PR for now: lazychaser/laravel-nestedset#441