twill:refresh-crops Fix wrong crops for Blocks
#2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrckvzn
changed the title
twill:refresh-crops Fix wrong crops for Blocks
ifox
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
php artisan twill:refresh-crops \\A17\\Twill\\Models\\Block block-imagewas returning an error "roleName not found" becasuegetMediaParams()it returningconfig('twill.default_crops')preventing from getting to the TwillBlock line. The returned array is then wrong for Blocks.This change checks is the model is an instance of blocks and then return the appropriate arrays of media params.
Related Issues
none