Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2044|#1818: Improve repeater cloning. #2160

Merged
merged 9 commits into from
Mar 10, 2023
Merged

#2044|#1818: Improve repeater cloning. #2160

merged 9 commits into from
Mar 10, 2023

Conversation

haringsrob
Copy link
Contributor

@haringsrob haringsrob commented Feb 24, 2023

#2044
#1818

Description

Adds a new action for cloning repeaters specifically. Also ensures the object is dereferenced when cloning blocks with repeaters inside.

@what-the-diff
Copy link

what-the-diff bot commented Feb 24, 2023

  • Fix the duplication of repeaters.
  • Add a new action to duplicate blocks in store/actions/index.js and handle it in actions, mutations and getFormData utils files (see diffs).

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (2ccd4a7) 59.90% compared to head (7d5fa2e) 59.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x    #2160      +/-   ##
============================================
- Coverage     59.90%   59.90%   -0.01%     
- Complexity     3904     3905       +1     
============================================
  Files           303      303              
  Lines         15039    15041       +2     
============================================
+ Hits           9009     9010       +1     
- Misses         6030     6031       +1     
Impacted Files Coverage Δ
src/Repositories/Behaviors/HandleBlocks.php 62.02% <50.00%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@haringsrob haringsrob merged commit 6c1674c into 3.x Mar 10, 2023
@haringsrob haringsrob deleted the fix-repeaters branch March 10, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant