Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source_path_prefix to Glide ServerFactory #2131

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Conversation

matteovg7
Copy link
Contributor

Description

Add source_path_prefix to Glide ServerFactory create params

@what-the-diff
Copy link

what-the-diff bot commented Feb 6, 2023

  • Added a new config option to allow for the source path prefix.
  • Updated Glide class constructor to pass in this value as an argument when creating the server instance.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 59.93% // Head: 59.94% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2996ace) compared to base (7d32d4c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.x    #2131   +/-   ##
=========================================
  Coverage     59.93%   59.94%           
  Complexity     3901     3901           
=========================================
  Files           303      303           
  Lines         15032    15033    +1     
=========================================
+ Hits           9010     9011    +1     
  Misses         6022     6022           
Impacted Files Coverage Δ
src/Services/MediaLibrary/Glide.php 55.88% <100.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2023

CLA assistant check
All committers have signed the CLA.

@haringsrob
Copy link
Contributor

Hey @matteovg7 thank you for your contribution. Can you add this to the default config file + add some documentation as well.

@matteovg7
Copy link
Contributor Author

Hi @haringsrob, I added the parameter to the default config file.
I don't know where to add the documentation but this is simply an additional parameter passed to the default glide configuration (https://glide.thephpleague.com/2.0/config/source-and-cache/)

@haringsrob
Copy link
Contributor

hey @matteovg7 it's fine like this. I will check if additional docs are required. We can only merge this pr after the cla has been completed.

config/glide.php Outdated Show resolved Hide resolved
@what-the-diff
Copy link

what-the-diff bot commented Mar 27, 2023

PR Summary

  • 🛠️ New config option added
    A new configuration option has been added to the glide.php file.
  • ⚙️ Glide class updated
    The Glide class constructor now uses the new configuration option.

@ifox ifox merged commit 0bae05b into area17:3.x Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants