3.4.0 - regression - "Don't load relation for each column and allow dot notation in field name for index table"

[jandol5]

Description

The 3.4.0 has introduced "Don't load relation for each column and allow dot notation in field name for index table" (#2603) which breaks previous behavior.

Steps to reproduce

Add additional relation index table columns in controller, eg

protected function additionalIndexTableColumns(): TableColumns
{
    return parent::additionalIndexTableColumns()
        ->add(Relation::make()->relation('measure')->field('title')->title('Naslov'))
        ->add(Relation::make()->relation('measure')->field('category.title')->title('Naziv kategorije'));
}

Expected result

Index table should have additional two columns:

• "Naslov" containing the title of the "measure" relation instance
• "Naziv kategorije" containing the title of category category relation of "measure" relation instance

Actual result

Using the dot notation in filed name throws Illuminate\Database\QueryException stating SQLSTATE[42S22]: Column not found: 1054 Unknown column 'category.title' in 'field list' (Connection: mysql, SQL: select category.titlefrommeasureswheremeasures.deleted_at is null).
When I remove Relation::make()->relation('measure')->field('category.title')->title('Naziv kategorije') and use only Relation::make()->relation('measure')->field('title')->title('Naslov'), the index table renders the additional 'Naslov' column but the data is wrong: all titles of all of the relation model instances are displayed.

Possible fix

The PR #2603 changes $relation type from \Illuminate\Database\Eloquent\Collection to \App\Models\[model] as seen in src/Services/Listings/Columns/Relation.php. If I replace the new $relation = $model->getRelation($this->relation); with previous $relation = $model->{$this->relation}()->get(); I get the expected result.

@Tofandel is this an innocent regression or did I miss something?

Versions

Twill version: 3.4.0
Laravel version: 11.28.0
PHP version: 8.3.4
Database engine: MySQL 5.7.24

[Tofandel]

Could you please share your models

$model->loadMissing($this->relation);
$relation = $model->getRelation($this->relation);

And

$relation = $model->{$this->relation}()->get();

Should be functionnally equivalent (except one uses the cache and one runs a query everytime)

Is measure a one to one relation?

Edit: just checked and yeah in one to one ->get still returns a collection but not getRelation

In the PR I mentionned that "however the Relation column doesn't actually use the loaded relation (and doesn't work with one to one relation)"

So I did try originally with a one to one and didn't get it to work, so I guess that's why I didn't catch this regression