[Package Capsules] Broken getModulePermalinkBase

[Tofandel]

Description

Package capsules which have a namespace different than config('twill.namespace') (Usually it's a namespace with the package name) will fail at

twill/src/Http/Controllers/Admin/ModuleController.php

Lines 2412 to 2448 in 17803f1

	protected function getModulePermalinkBase(): string
	{
	$base = '';
	$moduleParts = explode('.', $this->moduleName);
	$prev = [];
	foreach ($moduleParts as $index => $name) {
	if (array_key_last($moduleParts) !== $index) {
	$singularName = Str::singular($name);
	$modelClass = config('twill.namespace') . '\\Models\\' . Str::studly($singularName);
	if (! @class_exists($modelClass)) {
	// First try to construct it based on the last.
	$modelClass = config('twill.namespace') .
	'\\Models\\' .
	implode('', array_merge($prev + [99 => Str::studly($singularName)]));
	// Last option is to search for a capsule model.
	if (! class_exists($modelClass)) {
	$modelClass = TwillCapsules::getCapsuleForModel($name)->getModel();
	}
	}
	$model = (new $modelClass())->findOrFail(request()->route()->parameter($singularName));
	$hasSlug = Arr::has(class_uses($modelClass), HasSlug::class);
	$base .= $name . '/' . ($hasSlug ? $model->slug : $model->id) . '/';
	$prev[] = Str::studly($singularName);
	} else {
	$base .= $name;
	}
	}
	return $base;
	}

because $name is not a model class but a simple singular no uppercased word

Steps to reproduce

Create a package with 2 capsules with nesting enabled

Go to the route for the nested capsule

Expected result

No error

Actual result

No capsule found for seminar

Versions

Quick fix would be to uppercase $name before getting the capsule

Better fix would be to build on #2423 and improve the way all the classes are located (and maybe add a cache as well)

[ifox]

Hi @Tofandel,

Thanks for reporting this. Capsules were initially meant to be self-contained and were all housed under the same namespace but with the introduction of packages, it is clear that those improvements are welcome. I'm open to reviewing more changes to make resolution cleaner and more robust.

[Tofandel]

I PR'd the quick fix for now, I'll send a PR to generalize and allow to configure all the namespaces resolutions sometime this month when I have more time