Refactor and add same fix for files replacement

area17 · Jun 2, 2021 · 6b7c23e · 6b7c23e
1 parent c531b28
commit 6b7c23e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Http/Controllers/Admin/FileLibraryController.php b/src/Http/Controllers/Admin/FileLibraryController.php
@@ -39,7 +39,7 @@ class FileLibraryController extends ModuleController implements SignUploadListen
     protected $defaultFilters = [
         'search' => 'search',
         'tag' => 'tag_id',
-        'unused' => 'unused'
+        'unused' => 'unused',
     ];
 
     /**
@@ -315,6 +315,6 @@ public function uploadIsNotValid()
      */
     private function shouldReplaceFile($id)
     {
-        return $this->repository->whereId($id)->exists();
+        return isset($id) ? $this->repository->whereId($id)->exists() : false;
     }
 }
diff --git a/src/Http/Controllers/Admin/MediaLibraryController.php b/src/Http/Controllers/Admin/MediaLibraryController.php
@@ -339,6 +339,6 @@ private function getExtraMetadatas()
      */
     private function shouldReplaceMedia($id)
     {
-        return $id == 'null' ? false : $this->repository->whereId($id)->exists();
+        return isset($id) ? $this->repository->whereId($id)->exists() : false;
     }
 }