-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several fixes #1872
Merged
Merged
Several fixes #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardatan
changed the title
fix(node-fetch/URL): parse IPV6 hostnames correctly in \
fix(node-fetch/URL): parse IPV6 hostnames correctly in Dec 10, 2024
URL\
, and also reflect changes in \toString\
when \searchParams\
modifiedURL
, and also reflect changes in toString
when searchParams
modified
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@whatwg-node/node-fetch |
0.7.5-alpha-20241210211414-d3ba0200610c3de61aea13ae4383d2db8ad54ac2 |
npm ↗︎ unpkg ↗︎ |
@whatwg-node/server |
0.9.61-alpha-20241210211414-d3ba0200610c3de61aea13ae4383d2db8ad54ac2 |
npm ↗︎ unpkg ↗︎ |
✅
|
✅
|
✅
|
✅
|
✅
|
ardatan
changed the title
fix(node-fetch/URL): parse IPV6 hostnames correctly in
Several fixes
Dec 10, 2024
URL
, and also reflect changes in toString
when searchParams
modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url.searchParams
parameter should reflect the changes intoString()
new URL('http://[::1]')
should parse the host as `[::1]` not `::1`.fetch
now handles parsed IPV6 URL instances correctlyctx.waitUntil
was not blockingSymbol.asyncDispose
methodAlso closes #1801