fix(node-fetch): support native File

ardatan · Dec 16, 2023 · f844a4d · f844a4d
1 parent b931ed4
commit f844a4d
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/.changeset/fluffy-mangos-rescue.md b/.changeset/fluffy-mangos-rescue.md
@@ -0,0 +1,5 @@
+---
+"@whatwg-node/node-fetch": patch
+---
+
+Support native File
diff --git a/packages/node-fetch/src/FormData.ts b/packages/node-fetch/src/FormData.ts
@@ -134,7 +134,11 @@ export function getStreamFromFormData(
 }
 
 function getNormalizedFile(name: string, blob: PonyfillBlob, fileName?: string) {
-  (blob as PonyfillFile).name = fileName || blob.name || name;
+  Object.defineProperty(blob as PonyfillFile, 'name', {
+    configurable: true,
+    enumerable: true,
+    value: fileName || blob.name || name,
+  });
   return blob as PonyfillFile;
 }
 

diff --git a/packages/node-fetch/tests/FormData.spec.ts b/packages/node-fetch/tests/FormData.spec.ts
@@ -150,4 +150,19 @@ describe('Form Data', () => {
     expect(requestText).toContain(`Content-Type: text/plain`);
     expect(requestText).toContain(`Hello world!`);
   });
+  if (globalThis.File) {
+    it('support native File', async () => {
+      const formData = new PonyfillFormData();
+      const file = new globalThis.File(['Hello world!'], 'greetings.txt', { type: 'text/plain' });
+      formData.append('greetings', file as any);
+      const request = new PonyfillRequest('http://localhost:8080', {
+        method: 'POST',
+        body: formData,
+      });
+      const requestText = await request.text();
+      expect(requestText).toContain(`Content-Disposition: form-data; name="greetings"`);
+      expect(requestText).toContain(`Content-Type: text/plain`);
+      expect(requestText).toContain(`Hello world!`);
+    });
+  }
 });