fix: use correct makepkg.conf location without silently failing #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo when implementing the new devtools makepkg.conf location. Unfortunately the code failed silently which made it not be detected until now. Fix this by using the correct location as well as switch to a simple fall-through approach so we can easily fail instead of silently and invisibly doing the wrong thing leading to false-negative unreproducible packages. Fixes 63ce751
kpcyrd
approved these changes
Feb 16, 2024
Foxboron
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo when implementing the new devtools makepkg.conf location. Unfortunately the code failed silently which made it not be detected until now.
Fix this by using the correct location as well as switch to a simple fall-through approach so we can easily fail instead of silently and invisibly doing the wrong thing leading to false-negative unreproducible packages.
Fixes 63ce751