feat(flag): add error when there are no supported security checks #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyLewen
requested review from
owenrumney,
liamg and
knqyf263
as code owners
knqyf263
reviewed
Aug 16, 2022
pkg/flag/scan_flags.go
Outdated
| switch { | ||
| case len(securityCheck) == 0: // no checks | ||
| return nil | ||
| return nil, xerrors.New("no security checks") |
There was a problem hiding this comment.
security-checks can be empty when generating SBOM
There was a problem hiding this comment.
I didn't think about it. Thanks. Fixed.
pkg/flag/scan_flags.go
Outdated
| case len(securityCheck) == 1 && strings.Contains(securityCheck[0], ","): // get checks from flag | ||
| securityCheck = strings.Split(securityCheck[0], ",") | ||
| } | ||
|
|
||
| var securityChecks []string | ||
| for _, v := range securityCheck { | ||
| if !slices.Contains(types.SecurityChecks, v) { | ||
| log.Logger.Warnf("unknown security check: %s", v) | ||
| continue | ||
| return nil, xerrors.New(fmt.Sprintf("unknown security check: %s", v)) |
There was a problem hiding this comment.
Suggested change
| return nil, xerrors.New(fmt.Sprintf("unknown security check: %s", v)) | |
| return nil, xerrors.Errorf("unknown security check: %s", v) |
knqyf263
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trivy doesn't stop scan if
--security-checksflag has only unsupported values.We need to return error when parsing the flags.
Before:
After:
Checklist