Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): scanResponse rpc conversion for custom resources #2692

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

ankk13
Copy link
Contributor

@ankk13 ankk13 commented Aug 9, 2022

Description

The server ftypes scan result when converted to RPC response using method ConvertToRPCScanResponse(), were dropping customerResources in conversion. This commit fixes the method to consider customResources as well

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@ankk13 ankk13 requested a review from knqyf263 as a code owner August 9, 2022 18:56
@ankk13 ankk13 changed the title fix(rpc): scanResponse rpc conversion for custom resources fix(server): scanResponse rpc conversion for custom resources Aug 9, 2022
@knqyf263 knqyf263 merged commit babfb17 into aquasecurity:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants