Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(image): skip symlinks and hardlinks from tar scan #2634

Merged
merged 2 commits into from
Aug 8, 2022
Merged

chore(image): skip symlinks and hardlinks from tar scan #2634

merged 2 commits into from
Aug 8, 2022

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Aug 1, 2022 •
edited
Loading

Description

symlinks and hardlinks have no content in tar reader.
Skip them.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner August 1, 2022 05:10
@knqyf263 knqyf263 requested a review from tonaim August 1, 2022 07:37
@knqyf263
Copy link
Collaborator

knqyf263 commented Aug 1, 2022

@tonaim Could you review this PR?

@knqyf263 knqyf263 merged commit 390c256 into main Aug 8, 2022
@knqyf263 knqyf263 deleted the skip-hardlinks-symlinks branch August 8, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@tonaim tonaim Awaiting requested review from tonaim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitriyLewen @knqyf263