Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix --file-patterns flag #2625

Merged
merged 2 commits into from
Jul 29, 2022
Merged

fix: Fix --file-patterns flag #2625

merged 2 commits into from
Jul 29, 2022

Conversation

liamg
Copy link
Contributor

@liamg liamg commented Jul 29, 2022

Resolves #2608

Signed-off-by: Liam Galvin [email protected]

Description

Fixes use of the --file-patterns flag. Defsec detection is now overridden when a custom file pattern is provided for the file type.

Related issues

Resolves #774

Signed-off-by: Liam Galvin <[email protected]>
@liamg liamg marked this pull request as ready for review July 29, 2022 08:31
@@ -39,6 +39,7 @@ func init() {
const version = 1

type misconfPostHandler struct {
options artifact.Option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we only store options.MisconfScannerOption.FilePatterns here?
I think we don't need to keep all "options".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's true, done 👍

@knqyf263 knqyf263 merged commit 27027cf into main Jul 29, 2022
@knqyf263 knqyf263 deleted the liamg-fix-file-patterns branch July 29, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trivy can scan dockerfile more than matching pattern Dockerfile*
4 participants