-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): secret scanning perf link fix #2607
Conversation
|
Hmm. We fixed it before. @DmitriyLewen Could you look into what causes? |
My first thought was to add an if-else like ver := fmt.Sprintf("v%s", opt.AppVersion)
if opt.AppVersion == "dev" {
ver = opt.AppVersion
} which is like essentially reverting #2422 There are three sources of the version I see
Currently, I have fixed it for goreleaser, I can also fix it for makefile |
Hello @knqyf263
I think we need to create same logic for both cases:
I think logic of this PR better. UPD.
|
It's no big deal, but it looks weird to me. What if we remove Line 1 in c2a7ad5
|
And add
|
Yes, doable. The documentation links will need to be updated to remove the |
@Moulick Could you fix it as below?
|
Should work as expected now. |
Signed-off-by: Moulick Aggarwal <[email protected]>
Signed-off-by: Moulick Aggarwal <[email protected]>
Signed-off-by: Moulick Aggarwal <[email protected]>
Signed-off-by: Moulick Aggarwal <[email protected]>
Signed-off-by: Moulick Aggarwal <[email protected]>
@Moulick Thanks for your great contribution and patience! |
@knqyf263 I'd be curious about the comment I added above 🤔. |
Which comment? |
|
Description
Fixes the URL in the logs of the scanner
Related issues
Before
After
Checklist