Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Introduce kube.Object as more generic representation of kube.Workload #71

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak [email protected]

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #71 into master will decrease coverage by 1.95%.
The diff coverage is 36.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #71      +/-   ##
=========================================
- Coverage   11.05%   9.10%   -1.96%     
=========================================
  Files          23      26       +3     
  Lines         859    1153     +294     
=========================================
+ Hits           95     105      +10     
- Misses        759    1043     +284     
  Partials        5       5              
Impacted Files Coverage Δ
pkg/find/vulnerabilities/trivy/scanner.go 0.00% <0.00%> (ø)
pkg/kube/object.go 34.48% <34.48%> (ø)
pkg/cmd/commands.go 56.41% <100.00%> (ø)
pkg/kube/runnable_job.go 0.00% <0.00%> (ø)
pkg/kube/cr_manager.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8474833...ca0799a. Read the comment docs.

@danielpacak danielpacak force-pushed the refactor_kube_workload_model branch 4 times, most recently from 558cf4a to 571b287 Compare June 24, 2020 11:12
@danielpacak danielpacak marked this pull request as ready for review June 24, 2020 11:13
@danielpacak danielpacak force-pushed the refactor_kube_workload_model branch from 571b287 to ca0799a Compare June 24, 2020 11:22
@danielpacak danielpacak requested a review from knqyf263 June 24, 2020 12:15
@danielpacak danielpacak merged commit 898d422 into master Jun 24, 2020
@danielpacak danielpacak deleted the refactor_kube_workload_model branch June 24, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants