Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle legacy image pull secrets of type kubernetes.io/dockercfg #577

Merged
merged 1 commit into from
May 14, 2021

Conversation

danielpacak
Copy link
Contributor

Resolves: #569

Signed-off-by: Daniel Pacak [email protected]

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #577 (e908c2c) into main (903d2fa) will increase coverage by 0.11%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   71.18%   71.29%   +0.11%     
==========================================
  Files          63       63              
  Lines        4074     4073       -1     
==========================================
+ Hits         2900     2904       +4     
+ Misses        854      848       -6     
- Partials      320      321       +1     
Impacted Files Coverage Δ
pkg/kube/secrets.go 60.56% <57.14%> (-0.05%) ⬇️
pkg/plugin/trivy/plugin.go 78.82% <100.00%> (-0.34%) ⬇️
pkg/operator/controller/vulnerabilityreport.go 70.37% <0.00%> (-1.24%) ⬇️
pkg/operator/controller/configauditreport.go 71.63% <0.00%> (+1.44%) ⬆️
pkg/operator/controller/ciskubebenchreport.go 66.11% <0.00%> (+3.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1943a...e908c2c. Read the comment docs.

@danielpacak danielpacak merged commit bd095bd into main May 14, 2021
@danielpacak danielpacak deleted the issue_569 branch May 14, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle legacy image pull secrets of type kubernetes.io/dockercfg
1 participant