Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trivy): Pass additional settings to Trivy client #547

Merged
merged 1 commit into from
May 19, 2021

Conversation

xyoxo
Copy link
Contributor

@xyoxo xyoxo commented May 1, 2021

Resolves: #541

@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #547 (f88f6d6) into main (1425f26) will increase coverage by 1.00%.
The diff coverage is 100.00%.

❗ Current head f88f6d6 differs from pull request most recent head 9646165. Consider uploading reports for the commit 9646165 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   70.63%   71.64%   +1.00%     
==========================================
  Files          58       63       +5     
  Lines        4029     4190     +161     
==========================================
+ Hits         2846     3002     +156     
- Misses        857      865       +8     
+ Partials      326      323       -3     
Impacted Files Coverage Δ
pkg/plugin/trivy/plugin.go 84.00% <100.00%> (+5.18%) ⬆️
pkg/starboard/config.go 75.72% <100.00%> (-0.42%) ⬇️
pkg/operator/controller/configauditreport.go 65.38% <0.00%> (-5.77%) ⬇️
pkg/operator/controller/vulnerabilityreport.go 69.54% <0.00%> (-0.50%) ⬇️
pkg/operator/operator.go 62.99% <0.00%> (-0.29%) ⬇️
pkg/cmd/root.go 100.00% <0.00%> (ø)
pkg/cmd/scan_vulnerabilityreports.go
pkg/cmd/scan_configauditreports.go
pkg/cmd/scan_kubehunterreports.go
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1425f26...9646165. Read the comment docs.

@xyoxo xyoxo force-pushed the trivy-settings branch from 0ebec17 to b66905d Compare May 1, 2021 18:04
@danielpacak danielpacak self-requested a review May 4, 2021 13:08
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xyoxo Please rebase this PR

@xyoxo xyoxo force-pushed the trivy-settings branch from b66905d to 7f7b0b1 Compare May 10, 2021 08:28
@xyoxo
Copy link
Contributor Author

xyoxo commented May 10, 2021

@xyoxo Please rebase this PR

@danielpacak Rebased.

@xyoxo xyoxo force-pushed the trivy-settings branch 4 times, most recently from f265cef to f88f6d6 Compare May 17, 2021 13:57
@danielpacak danielpacak merged commit e1cb116 into aquasecurity:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(trivy): Pass additional settings to Trivy client
2 participants